-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Update Kubernetes client libraries to 1.15.0 release #495
Conversation
In cluster-api project, we are looking to switch to go.mod, v2 project structure, k8s 1.15.0 in one sweep. |
/assign @DirectXMan12 |
Are there any major blockers to get this merged? 1.15 brings beta support for CustomResourceWebhookConversion :) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tamalsaha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DirectXMan12 , pr is ready for review. I have fixed the conflicts from the jsonpatch fix. |
FWIW... LGTM... I'd like to see these libraries updated for 1.15.0 ASAP too. |
whoops, looks like there's an extra commit, and you've checked in the vendor directory, which we stopped doing. |
Signed-off-by: Tamal Saha <tamal@appscode.com>
@DirectXMan12 , it is fixed now. I think |
@DirectXMan12 / @mengqiy / @droot , anyone mind taking a look? Are there any blockers to getting this merged? |
Any updates on this? |
@tamalsaha @DirectXMan12 I think we should hold off on this, until after the |
/hold we'll do a couple releases in quick succession for this (v0.2.0 and v0.2.1) assuming there's nothing breaking here (will need to double-check, but I don't think so). |
I'm not sure if it's related, but #500—though closed—describes some version incompatibilities with the dependencies. |
@magrossm , this library now lives here: https://github.com/gomodules/jsonpatch You should use |
Folks, I am not looking to further work on this pr. So, I am closing this. Feel free to copy/create a new pr. |
Yes but how do I bind it in? I want to install clusterapi clusterctl and I cannot find go.mod.
|
Yeah, sorry about all the delay @tamalsaha. We'll prob pick this up shortly now that v2 is out. |
@magrossm please ask the cluster-api folks. They're probably using dep (if you see a Gopkg.tom file) |
update how to build kubebuilder locally
Signed-off-by: Tamal Saha tamal@appscode.com