No list option for Continue or Limit

[grantr]

The new functional list options from #294 don't support setting Limit or Continue with a functional option. If the user wants to use those options, they need to fall back to UseListOptions. Not a huge deal, but probably not too hard to fix.

[DirectXMan12]

/kind feature
/priority backlog
/good-first-issue

[rajathagasthya]

@DirectXMan12 Can I take this?

[DirectXMan12]

go ahead! Always happy for more contributions :-)

[rajathagasthya]

@DirectXMan12 Thanks! Do you have any pointers on how to get started with this? How are the Limit and Continue options used?

[DirectXMan12]

basically, you'd just need to implement additional ListOptionsFunc implementations that set limit and continue on the list options -- the pattern should be fairly straightforward if you look at some of the other list options, but LMK if it's unclear (see, for example https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/interfaces.go#L304)

Limit and continue themselves are used as part of the paginated list API in Kubernetes (e.g. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#list)

[rajathagasthya]

@DirectXMan12 Thanks! I actually figured out what to do after reading some code in k/k. I'm writing tests (which are failing so far), but I'll create a WIP PR to make sure I'm doing the right things.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.