-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ClusterClass: Introduce NamingStrategy and allow generating names using go templates #9340
✨ ClusterClass: Introduce NamingStrategy and allow generating names using go templates #9340
Conversation
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
cd17b46
to
bb50446
Compare
/test pull-cluster-api-e2e-full-main |
bb50446
to
bd07910
Compare
/test pull-cluster-api-e2e-full-main |
bd07910
to
a5ada5c
Compare
4716186
to
83fe2ea
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
ae7c56e
to
1a28aa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on the very straightforward implementation - I thought it would be much more complex.
Just a couple of nits and a follow up from my side.
@@ -25,7 +25,6 @@ import ( | |||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine as a follow-up, but we should document how to do this in the ClusterClass docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which part of the docs do you think would this fit into?
I think for other fields we usually didn't write docs apart from godocs / descriptions for the CRD
(follow-up sounds fine in any case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd do this in a follow-up PR :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup let's just discuss first what we want to document where before we do it ;)
1a28aa5
to
a0421a8
Compare
a0421a8
to
e58176d
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: 72034d79b1f268864c572e80cbf2a52c62eb6e0a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: #9340 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Introduces the NamingStrategy struct at the ClusterClass level for:
Also introduces a new package which exposes functions and a interface to generate names.
TODO:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #9323