-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ : Remove go-vcs dependency from releaselink tool #9288
⚠️ : Remove go-vcs dependency from releaselink tool #9288
Conversation
d10b3eb
to
57abb96
Compare
/area util |
57abb96
to
4c2118a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area
/lgtm +/- migration note |
LGTM label has been added. Git tree hash: be9c0b98e9fffad448b17a81b3e34b5b2c1d2d25
|
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
4c2118a
to
2c38961
Compare
Added a note. |
Thx! /lgtm I assume when the repo tag is not added the book generation will just fail pretty hard? (with the errors we return) |
LGTM label has been added. Git tree hash: 2b27ff83554fd29d291ef7839873a90e9b9eee8d
|
Yeah - mdbook fails with an error locally. I've pushed a failing commit to ensure this also happens in CI. |
/hold For failing commit |
Link to CI result when not using the tag: https://app.netlify.com/sites/kubernetes-sigs-cluster-api/deploys/64e61eacf90b8f000814236d I've removed the failing commit now. |
e4bb91b
to
2c38961
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 2b27ff83554fd29d291ef7839873a90e9b9eee8d
|
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a required "repo" tag to passed into usages of the
releaselink
tool. This is required in order to get rid of the deprecated"golang.org/x/tools/go/vcs"
This is a breaking change for downstream users of this tool who will have to add the new var - but it seemed simpler and easier to maintain than copying over the module -> repo resolution code from the go VCS tool.
Fixes #9063