-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove disableInPlacePropagation field in KCP controller #9099
🌱 Remove disableInPlacePropagation field in KCP controller #9099
Conversation
Welcome @Anddd7! |
Hi @Anddd7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks for addressing this
|
Thank you very much! I assumed we would have to change more, but nice small change :) (especially for the scale test) /retitle 🌱 Remove disableInPlacePropagation field in KCP controller |
/lgtm |
LGTM label has been added. Git tree hash: 3702768e8df3c416c634573a602e1b64185eb263
|
/hold |
@Anddd7 Can you please squash the commits to just a single commit? Thank you! |
Signed-off-by: Anddd7 <liaoad_space@sina.com>
Thank you |
LGTM label has been added. Git tree hash: ea432ae78ea9ed33611aabe16c15f8e6e2e58938
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Remove the unnecessary indicator
disableInPlacePropagation
, which is only used in testsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8393