-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use CreateAndWait in MP ScaleFromZero test #8927
🐛 Use CreateAndWait in MP ScaleFromZero test #8927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area testing
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
5ee0bf4
to
8cc18be
Compare
/retitle 🐛 Use CreateAndWait in MP ScaleFromZero test |
/hold cancel Test green for me with ~30K runs on my machine. I caught the flake in action and it seems like it was down to the node not being available when reconcile was called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, and huge kudos for the relentless work on flakes
/lgtm
/approve
LGTM label has been added. Git tree hash: 7d95ba733015718d3919a84db494ecd48a71629b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add an eventually to the test
Should delete retired nodes when scaled to zero
for the MachinePool reconciler. This started flaking recently, likely due to changes in the use of the clusterCacheTracker in this reconciler.