-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove unnecessary requeues #8743
🌱 Remove unnecessary requeues #8743
Conversation
/test pull-cluster-api-e2e-full-main |
Signed-off-by: Stefan Büringer buringerst@vmware.com
ee582b2
to
c1ef1d7
Compare
This PR is ready for review. I'll hold it to be able to do a before/after comparison with goofy. /assign @fabriziopandini @ykakarap @killianmuldoon @CecileRobertMichon |
if err := r.externalTracker.Watch(log, obj, handler.EnqueueRequestForOwner(r.Client.Scheme(), r.Client.RESTMapper(), &expv1.MachinePool{})); err != nil { | ||
return external.ReconcileOutput{}, err | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the watch above the pause so that we always watch even if the object is paused right now
/test pull-cluster-api-e2e-full-main |
/test pull-cluster-api-e2e-mink8s-main (Just to verify it works) |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Nice cleanup! |
LGTM label has been added. Git tree hash: 3a515002a58d3596e3d919b14f22ccb0cc6c977e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area provider/core
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR removes requeues in places where we already watch objects.
E.g. we don't have to requeue if the BootstrapConfig is not ready, because an update on a BootstrapConfig automatically triggers a reconcile (because we have a watch on BootstrapConfigs).
There should be no problems with stale caches after updates because we don't cache unstructured.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8735