Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Merge ownerReference tests with quick start #8264

Merged

Conversation

killianmuldoon
Copy link
Contributor

Merge the ownerReference quick start tests with the existing quick start tests. This means we're running fewer total tests, and the ownerReference check doesn't add appreciably to the length of the test run for quick start.

The ownerReference tests have not been flaky so far in the CI.
/area testing

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2023
@killianmuldoon
Copy link
Contributor Author

/retitle 🌱 Merge ownerReference tests with quick start #8264

@k8s-ci-robot k8s-ci-robot changed the title [WIP] 🌱 Merge ownerReference tests with quick start 🌱 Merge ownerReference tests with quick start #8264 Mar 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@sbueringer
Copy link
Member

/retitle 🌱 Merge ownerReference tests with quick start

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Merge ownerReference tests with quick start #8264 🌱 Merge ownerReference tests with quick start Mar 15, 2023
@sbueringer
Copy link
Member

sbueringer commented Mar 15, 2023

/lgtm
/approve

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0964f2bff7a2673cdd72882868d1e82cb785aefe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 08320d5 into kubernetes-sigs:main Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 15, 2023
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8287

In response to this:

/lgtm
/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants