Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/framework: don't fix kubeconfig for remote CAPD clusters #8241

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 7, 2023

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR changes the fix kubeconfig logic so that we only adjust the kubeconfig when necessary.

Specifically it only makes sense to fix the kubeconfig when the CAPD cluster is running locally in Docker Desktop.

It is not necessary if the CAPD cluster is running on a remote host. Actually for remote clusters fixing the kubeconfig breaks the kubeconfig as the remote cluster is not available under 127.0.0.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b0e3f56ceeb08f6de1563a3fa0e617bc55d4f4e

@sbueringer
Copy link
Member Author

/retest
(unrelated flake)

/test pull-cluster-api-e2e-full-main

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 9, 2023

@sbueringer, with no rush, let's demo during office hours how to use a remote docker-engine, that's a nice feature to have

@k8s-ci-robot k8s-ci-robot merged commit 714048e into kubernetes-sigs:main Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 9, 2023
@sbueringer sbueringer deleted the pr-e2e-remote-docker branch March 10, 2023 02:41
@sbueringer
Copy link
Member Author

sbueringer commented Mar 10, 2023

@sbueringer, with no rush, let's demo during office hours how to use a remote docker-engine, that's a nice feature to have

Yup good idea, will do. Probably after easter in April

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants