-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/framework: don't fix kubeconfig for remote CAPD clusters #8241
🌱 test/framework: don't fix kubeconfig for remote CAPD clusters #8241
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8b0e3f56ceeb08f6de1563a3fa0e617bc55d4f4e
|
/retest /test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer, with no rush, let's demo during office hours how to use a remote docker-engine, that's a nice feature to have |
Yup good idea, will do. Probably after easter in April |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR changes the fix kubeconfig logic so that we only adjust the kubeconfig when necessary.
Specifically it only makes sense to fix the kubeconfig when the CAPD cluster is running locally in Docker Desktop.
It is not necessary if the CAPD cluster is running on a remote host. Actually for remote clusters fixing the kubeconfig breaks the kubeconfig as the remote cluster is not available under 127.0.0.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #