Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][DNR] 🌱 Improve & fix KCP remediation e2e test #8075

Closed
wants to merge 8 commits into from
Closed

[WIP][DNR] 🌱 Improve & fix KCP remediation e2e test #8075

wants to merge 8 commits into from

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 7, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Trying out a fix for 7963, xref: #7963 (comment)

PLEASE DO NOT REVIEW, review 7963 instead. Thx :)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2023
@sbueringer sbueringer mentioned this pull request Feb 7, 2023
Merged
@sbueringer sbueringer changed the title [WIP][DNR] Improve & fix KCP remediation e2e test [WIP][DNR] 🌱 Improve & fix KCP remediation e2e test Feb 7, 2023
@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch from b27c1f5 to 8f6c71a Compare February 7, 2023 16:26
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

Flake :/

The e2e test I wanted to check actually worked

@sbueringer
Copy link
Member Author

/retest

1 similar comment
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch from e5ca1d9 to 8bb56d0 Compare February 8, 2023 15:55
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch from 8bb56d0 to 7ec3a5e Compare February 9, 2023 11:17
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch from 7ec3a5e to 7cf0192 Compare February 9, 2023 11:18
@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch 2 times, most recently from 3503739 to fb0dc90 Compare February 9, 2023 11:37
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Fixups
1528532 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-improve-kcp-remediation-2-linux-e2e branch from fb0dc90 to 1528532 Compare February 9, 2023 12:36
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

unrelated flake of the self-hosted test

/retest

@sbueringer
Copy link
Member Author

unrelated flake of the self-hosted test (again)

/retest

@sbueringer
Copy link
Member Author

unrelated flake of the self-hosted test (again again)

/retest

Maybe I should try tomorrow outside of the US working hours..

@sbueringer
Copy link
Member Author

Changes have been integrated in 7963

@sbueringer sbueringer closed this Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @jackfrancis @fabriziopandini