Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 docs update jobs.md for 1.26 #7802

Merged
merged 1 commit into from
Jan 11, 2023
Merged

📖 docs update jobs.md for 1.26 #7802

merged 1 commit into from
Jan 11, 2023

Conversation

aniruddha2000
Copy link
Contributor

Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com

part of #7671

cc @kubernetes-sigs/cluster-api-release-team

Q: Do we have to add a 1-26-latest after line 126?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2022
@sbueringer
Copy link
Member

/hold

@aniruddha2000 Let me review the test-infra PR (kubernetes/test-infra#28309) first (~ first January week), then we can update this PR accordingly

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
fabriziopandini
fabriziopandini reviewed Dec 29, 2022
View reviewed changes
docs/book/src/reference/jobs.md Outdated Show resolved Hide resolved
docs/book/src/reference/jobs.md Show resolved Hide resolved
sbueringer
sbueringer reviewed Jan 2, 2023
View reviewed changes
docs/book/src/reference/jobs.md Outdated Show resolved Hide resolved
docs/book/src/reference/jobs.md Outdated Show resolved Hide resolved
docs/book/src/reference/jobs.md Outdated Show resolved Hide resolved
docs/book/src/reference/jobs.md Outdated Show resolved Hide resolved
docs/book/src/reference/jobs.md Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jan 2, 2023
Closed
13 tasks
@aniruddha2000
docs update jobs.md for 1.26
2ccaa64 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@sbueringer
Copy link
Member

Thx!

/lgtm

Let's keep the hold until:

Just that we have support for v1.26 in the v1.3 and v1.2 branches before we change our jobs and that we actually have the jobs before we update our documentation

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 003ef0d5a6d4699f88662356c9cb27b771319f96

@cpanato
Copy link
Member

cpanato commented Jan 4, 2023

/lgtm

killianmuldoon
killianmuldoon approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2023
@sbueringer
Copy link
Member

/cherry-pick release-1.3

(no further cherry-picks needed)

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

(no further cherry-picks needed)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 584abcf into kubernetes-sigs:main Jan 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 11, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 11, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7898

In response to this:

/cherry-pick release-1.3

(no further cherry-picks needed)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@oscr oscr Awaiting requested review from oscr

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@cpanato cpanato

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@aniruddha2000 @sbueringer @k8s-ci-robot @cpanato @k8s-infra-cherrypick-robot @fabriziopandini @killianmuldoon