Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🐛 Add name hashing for long MS and KCP names #7743

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[release-1.2] 🐛 Add name hashing for long MS and KCP names #7743

merged 1 commit into from
Dec 13, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Manual cherry pick of #7711

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2022
@killianmuldoon
Add name hashing for long MS names
435dbda 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon killianmuldoon changed the title 🌱 [WIP] Add name hashing for long MS names 🌱 Add name hashing for long MS names Dec 13, 2022
@fabriziopandini fabriziopandini changed the title 🌱 Add name hashing for long MS names [release-1.2] 🌱 Add name hashing for long MS names Dec 13, 2022
@fabriziopandini fabriziopandini changed the title [release-1.2] 🌱 Add name hashing for long MS names [release-1.2] 🐛 Add name hashing for long MS names Dec 13, 2022
ykakarap
ykakarap approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5cac1d0 into kubernetes-sigs:release-1.2 Dec 13, 2022
@sbueringer sbueringer changed the title [release-1.2] 🐛 Add name hashing for long MS names [release-1.2] 🐛 Add name hashing for long MS and KCP names Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @fabriziopandini @k8s-ci-robot @ykakarap