-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [release-1.6] docker: ignore kubeadm preflight check for FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables #10938
🐛 [release-1.6] docker: ignore kubeadm preflight check for FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables #10938
Conversation
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-mink8s-release-1-6 /cherry-pick release-1.5 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold We may want this on main first and cherry-pick to all branches. |
…bridge-bridge-nf-call-ip6tables
4a619f4
to
b1d5dd3
Compare
Forgot to push unit test fix /test pull-cluster-api-e2e-mink8s-release-1-6 |
/retest |
/lgtm @chrischdi If we only need this ignore on this branch (and release-1.5), then I would prefer to only ignore it on old branches. My general goal would be only to ignore what we have to ignore so that we surface as much "real" findings as possible |
LGTM label has been added. Git tree hash: 9272648f005c8900d2dc2096088ef1897e17d65e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It anyway only affects CAPD so we're fine to not have it on main :-) /hold cancel |
Even older CAPD versions are even ignoring all preflight checks. So we still have a trend of generally ignoring less preflight checks the newer CAPD gets :D (if you only look at latest patch versions) |
I guess that's a machinepool flake /retest |
@chrischdi: #10938 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Looks like
br-netfilter
is not loaded anymore in CI.This ignores the preflight check which also got dropped in v1.30.
xref Slack
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Area example:
/area provider/infrastructure-docker