-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix race condition in TestPatchHelper test #10886
🐛 Fix race condition in TestPatchHelper test #10886
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/assign @chrischdi @fabriziopandini |
/test pull-cluster-api-test-mink8s-main |
Let's run both test jobs a few times and if all is green, let's merge it and check testgrid tomorrow again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: aad0cf79a6343ef67eb18f3346bbf900d7e06fe4
|
/hold to run the tests |
/test pull-cluster-api-mink8s-main |
/test pull-cluster-api-mink8s-main (with the new runs we will have 3x in a row) |
/test pull-cluster-api-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This test has been failing pretty regularly since we merged the test yesterday (#10866)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #