✨ Extend cluster builtin to include UID #10822
Conversation
k8s-ci-robot
added
area/runtime-sdk
srm09
force-pushed
the
add-uid-to-cluster-builtins
branch
from
bac6d8a
to
d43cae4
Compare
k8s-ci-robot
added
size/S
exp/runtime/hooks/api/v1alpha1/topologymutation_variable_types.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
This patch extends the cluster builtins to include the UID of the Cluster object. This can be used by the runtime extensions or JSON patches to set owner references on objects owned by the Cluster object. Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
add-uid-to-cluster-builtins
branch
from
d43cae4
to
ed38302
Compare
k8s-ci-robot
added
size/M
|
/retest The failures are unrelated to the changes introduced |
|
/retest |
|
Agree @fabriziopandini can you please PTAL when you have some time? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10822/pull-cluster-api-test-main/1808538566179950592 (this CRS test seems familiar) (Same test failing 2 of 3 times in a row) |
|
/retest |
|
Thank you! /lgtm |
|
/cherry-pick release-1.7 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b5470cc7e10b577bc99ae5799c7ca39ad29f9804
|
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #10831 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This patch extends the cluster builtins to include the UID of the Cluster object. This can be used by the runtime extensions or JSON patches to set owner references on objects owned by the Cluster object.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10823
/area runtime-sdk
/area clusterclass