-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add support for the linode-linode infrastructure provider to clusterctl #10471
🌱 Add support for the linode-linode infrastructure provider to clusterctl #10471
Conversation
Welcome @eljohnson92! |
Hi @eljohnson92. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area clusterctl |
Please take a look: #10471 (comment) |
@sbueringer This should now be all set |
/lgtm |
LGTM label has been added. Git tree hash: 1466e326696b94362dd690899fb543cf043c4c80
|
05a0807
to
b9eb9f2
Compare
/retest |
1 similar comment
/retest |
db206f9
to
c4ba378
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
No big opinion on the quickstart wording which is okay for me, but happy to hear other maintainers how they think about it :-)
Thanks @eljohnson92
LGTM label has been added. Git tree hash: 2add65029f87bd7e13213ad4a2cfafa7a348e2bf
|
/cherry-pick release-1.7 To make it usable soon'ish. |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thx! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #10512 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR adds an infrastructure provider for Akamai Connected Cloud (Linode)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #