Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add MachinePools to handler and topology test #10216

Merged

Conversation

willie-yao
Copy link
Contributor

What this PR does / why we need it:
This PR adds MachinePools to the unit tests in handler_test.go and topology_test.go. This is a follow-up task to enabling MachinePools in ClusterClass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #10028

/area clusterclass

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
@willie-yao willie-yao changed the title 🌱 WIP: Add MachinePools to handler and topology test 🌱 Add MachinePools to handler and topology test Mar 1, 2024
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Just two nits

test/extension/handlers/topologymutation/handler_test.go Outdated Show resolved Hide resolved
test/extension/handlers/topologymutation/handler_test.go Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c29e4cb6cb3aa64f96118da448a7479ef189f654

@sbueringer
Copy link
Member

Thank you!!

/approve

Really appreciate your ongoing work on this!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

Not sure what that was:

test/extensiontest/extension/handlers/lifecycletest/extension/handlers/topologymutation

=== Failed
=== FAIL: test/extension/handlers/topologymutation  (0.00s)
FAIL	sigs.k8s.io/cluster-api/test/extension/handlers/topologymutation [build failed]

Let's see if it repeats

@sbueringer
Copy link
Member

sbueringer commented Apr 8, 2024

@willie-yao Can you please look into it? I'm guessing some compile error in tests (potentially only reproducible locally after rebase onto main)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@willie-yao
Copy link
Contributor Author

@sbueringer Should be fixed now!

@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5aadfa98d957a8a4a5b10a33ca6c0469036bca20

@k8s-ci-robot k8s-ci-robot merged commit f4e287f into kubernetes-sigs:main Apr 8, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants