Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubelet Config #8670

Closed
Bo0km4n opened this issue May 16, 2023 · 7 comments
Closed

Support Kubelet Config #8670

Bo0km4n opened this issue May 16, 2023 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Bo0km4n
Copy link
Contributor

Bo0km4n commented May 16, 2023

What would you like to be added (User Story)?

In currently, when user add additional config of kubelet, user add params to KubeadmConfigSpec resource .spec.joinConfiguration.nodeRegistration.kubeletExtraArgs.

But, recently kubelet warns some args will be removed and recommended that should be set via config file specified by kubelet's --config flag.
So when we use new version Kubernetes, this how to specify kubelet args maybe will be cannot use I think.

Therefore, I suggest to make setting KubeletConfig (https://pkg.go.dev/k8s.io/kubelet/config/v1beta1#KubeletConfiguration) via KubeadmConfig resource.

Detailed Description

NONE

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

The KubeadmConfig used in CAPI is a mostly a mirror of the upstream type - https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/. I'm not sure if the CAPI type is currently missing anything included in the upstream type. But I don't think including the full kubelet config is a real option here as it would be confusing to users.

One option for setting the KubeadmConfig would be to directly pass a file into the KubeadmConfig

This is a very interesting discussion though - I think it's linked to #8425

@neolit123
Copy link
Member

ideally, CAPI should let kubeadm manage the kubeletconfiguration v1beta1 GVK.

I think it's linked to #8425

+1 to close in favor of 8425, where documenting existing approaches was proposed.

@Bo0km4n
Copy link
Contributor Author

Bo0km4n commented May 16, 2023

@killianmuldoon @neolit123
Thanks for your mentions.
Kubelet config contents are common and fixed, so I will try to set parameters of that via KubeadmConfigSpec .files.

@musaprg
Copy link
Member

musaprg commented May 16, 2023

I prepared several examples for #8425. This would help for this purpose.

https://github.com/musaprg/cluster-api-kubelet-config-examples/blob/a46c8c80aa9b194cfda22747b14eaf4a0b86cca7/clusters/cloudinit/kubeadmcontrolplanetemplate.yaml#L10

@fabriziopandini
Copy link
Member

I have copied the last comment to #8425 (thanks @musaprg for the example), so we can continue the discussion there.
/close

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

I have copied the last comment to #8425 (thanks @musaprg for the example), so we can continue the discussion there.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

6 participants