Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 clusterctl init fails with 'failed to get cert-manager object' #6051

Closed
killianmuldoon opened this issue Feb 2, 2022 · 4 comments · Fixed by #6050
Closed

🐛 clusterctl init fails with 'failed to get cert-manager object' #6051

killianmuldoon opened this issue Feb 2, 2022 · 4 comments · Fixed by #6050
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@killianmuldoon
Copy link
Contributor

killianmuldoon commented Feb 2, 2022

clusterctl init is failing with an error 'failed to get cert-manager object'. This is due to cert-manager changing its repo location (from github.com/jetstack to github.com/cert-manager).

The solution for this issue is to add the new URL to the clusterctl config file, as described here, adding:

cert-manager:
  url: "https://github.com/cert-manager/cert-manager/releases/latest/cert-manager.yaml"

Alternatively users can use the clusterctl overrides folder to install the cert-manager from a yaml as described here

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2022
@fabriziopandini
Copy link
Member

/milestone v1.2
This is due to the GitHub client, that uses owner and repository from the above URL but it doesn't detect the URL redirect.

Let's change the URL as a quick fix, but long term we should implement URL redirect check in clusterctl, eventually rewriting the owner/repository passed to the GitHub client.

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 2, 2022
@fabriziopandini
Copy link
Member

(fix to be backported up to 0.4)

@killianmuldoon
Copy link
Contributor Author

I'll open another issue around the github client once the fix is in.

@sbueringer
Copy link
Member

sbueringer commented Feb 2, 2022

Just fyi. The DownloadRelesaeAsset func of the GitHub client is actually following redirects. But I think the issue is that we are retrieving a release (including assets) from a release of the new location and then passing in the owner of the old location.

But the fix stays the same, we have to detect the change and pass the right owner/repository through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants