🌱 Add verify-import-restrictions to enforce import restrictions

[laozc]

What this PR does / why we need it:
This PR introduces a new make target verify-import-restrictions to verify imports in source codes
to prevent regression mentioned in #2159.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2159

[k8s-ci-robot]

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (df01a95) 50.27% compared to head (34bcb8f) 50.16%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   50.27%   50.16%   -0.12%     
==========================================
  Files          87       87              
  Lines        8041     8041              
==========================================
- Hits         4043     4034       -9     
- Misses       3673     3680       +7     
- Partials      325      327       +2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[laozc]

It looks like the behavior is not consistent on different machine.
I will take a look.

[sbueringer]

One nit.

Nice catch!!

[sbueringer]

@laozc If you want / have time you can open the same PR against core CAPI once we merge this PR in CAPV (we can only add import-restrictions to the packages that are already fixed, but that is fine, xref: kubernetes-sigs/cluster-api#9011 (comment))

(otherwise we can take the core CAPI part)

[killianmuldoon]

/ok-to-test

[sbueringer]

Thank you!!

/lgtm

/assign @killianmuldoon @chrischdi

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 81840bfa1b54a5aadd9b68beef022d5546902fd9

[laozc]

Sure. I will open up a PR against CAPI later.

[chrischdi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment