This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Adds archiveOnDelete parameter to nfs-client provisioner. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
wongma7
reviewed
Aug 8, 2018
| // If it exists and has a value of false, delete the directory. | ||
| // Otherwise, archive it. | ||
| archiveOnDelete, exists := storageClass.Parameters["archiveOnDelete"] | ||
| if exists && archiveOnDelete == "false" { |
There was a problem hiding this comment.
slightly prefer to use strconv.ParseBool here
|
/lgtm |
gmorse81
force-pushed
the
nfs-client-support-delete
branch
from
f7ee109
to
2770057
Compare
|
@wongma7 i squashed, but also removed an extra blank line that didn't need to be there. the lgtm was removed. |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596
Adds archiveOnDelete parameter to nfs-client storageClass. Allows user to disable the archiving functionality. Sets the examples and readme to use this behavior.
If this parameter is not included, the old functionality will still work.