Build Node Driver Registrar for Windows nodes #47

ddebroy · 2019-08-14T07:32:34Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This PR adds support to build the Node Driver Registrar as a Windows binary: csi-node-driver-registrar.exe. The goal is to be able to build and publish container images for Windows using the Dockerfile.Windows. Daemonsets for CSI node plugins targeting Windows nodes can specify the Windows container packaging the Node Driver Registrar as a side-car just like in Linux.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The changes and build infra necessary to be able to build the Windows containers packaging csi-node-driver-registrar.exe is not yet present.

Does this PR introduce a user-facing change?:

Support Node Driver Registrar on Windows nodes

k8s-ci-robot · 2019-08-14T07:32:35Z

Welcome @ddebroy!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

ddebroy · 2019-08-14T07:33:14Z

/cc @pohly

ddebroy · 2019-08-14T07:42:56Z

Not sure why the changes to the build.make file are not allowed under sub-tree release-tools.

msau42 · 2019-08-14T16:03:26Z

cmd/csi-node-driver-registrar/util_windows.go

+// +build windows
+
+/*
+Copyright 2018 The Kubernetes Authors.


msau42 · 2019-08-14T16:04:50Z

release-tools/build.make

@@ -63,6 +63,7 @@ endif
 build-%:
 	mkdir -p bin
 	CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-X main.version=$(REV) -extldflags "-static"' -o ./bin/$* ./cmd/$*
+	CGO_ENABLED=0 GOOS=windows go build -a -ldflags '-X main.version=$(REV) -extldflags "-static"' -o ./bin/$*.exe ./cmd/$*


do we also need to modify container and push rules?

Yes. That is the part that needs a bit of discussion and research to get a Windows build platform in the picture since the Windows containers can only be built on Windows hosts.

msau42 · 2019-08-14T16:06:37Z

release-tools/build.make

@@ -63,6 +63,7 @@ endif
 build-%:


Any changes to files under release-tools need to be made in https://github.com/kubernetes-csi/csi-release-tools, and then merged in the respective repos. It's fine to make initial changes here for testing purposes, but once we determine it's good, then we need to make the PR against csi-release-tools first.

msau42 · 2019-08-14T16:07:02Z

/assign @msau42 @jingxu97

k8s-ci-robot · 2019-08-14T16:07:03Z

@msau42: GitHub didn't allow me to assign the following users: jingxu97.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @msau42 @jingxu97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msau42 · 2019-08-20T20:05:29Z

This lgtm. Go ahead and send a PR to csi-release-tools with the windows build rule

jingxu97 · 2019-08-21T19:17:19Z

cmd/csi-node-driver-registrar/util_linux.go

+)
+
+func umask(mask int) (int, error) {
+	return unix.Umask(mask), nil


why put it in a wrapper function? what is purpose of error here?

We need the wrapper function to able to allow platform dependent building (and essentially skip umask for Windows). The error is necessary in the Windows wrapper to clearly indicate that umask is not implemented on Windows. So we need the error returned for the _linux case as well to keep go happy.

With this wrapper function, do you still need to check OS in the code when using umask?

if runtime.GOOS == "linux" { // Default to only user accessible socket, caller can open up later if desired oldmask, _ = umask(0077) }

Indeed - not necessary. I added the above to make it doubly clear that umask is only intended for the Linux case. Someone looking at the code won't have to navigate to the umask wrapper to find out it is not implemented for Windows. I can skip the check above if that is recommended.

Signed-off-by: Deep Debroy <ddebroy@docker.com>

ddebroy · 2019-08-28T13:10:55Z

I removed the Windows build rule in this PR as instructed at #47 (comment). PTAL @msau42 @jingxu97

ddebroy · 2019-08-28T13:26:50Z

Needs kubernetes-csi/csi-release-tools#26 to generate the actual binary.

msau42 · 2019-08-29T17:06:35Z

/test pull-kubernetes-csi-node-driver-registrar-1-13-on-kubernetes-1-13

msau42 · 2019-08-29T17:06:47Z

/assign @jingxu97

k8s-ci-robot · 2019-08-29T17:06:49Z

@msau42: GitHub didn't allow me to assign the following users: jingxu97.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jingxu97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jingxu97 · 2019-09-04T21:58:43Z

Dockerfile.Windows

+
+COPY ./bin/csi-node-driver-registrar.exe /csi-node-driver-registrar.exe
+COPY --from=core /Windows/System32/netapi32.dll /Windows/System32/netapi32.dll
+USER ContainerAdministrator


Just want to double check this is a must setting.

This is needed for the node driver registrar to be able to connect to the unix domain socket surfaced by the node CSI plugin (which also needs to be started as ContainerAdministrator).

jingxu97 · 2019-09-04T23:34:27Z

/lgtm

k8s-ci-robot · 2019-09-04T23:34:33Z

@jingxu97: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andyzhangx · 2019-09-05T07:50:55Z

thanks, we may also make windows build in travis CI in the future, to make this driver could always run on windows

andyzhangx · 2019-09-05T07:51:25Z

and someone could merge this PR? Thanks.

msau42 · 2019-09-05T17:52:46Z

/lgtm
/approve

k8s-ci-robot · 2019-09-05T17:52:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Adding build for ppc64le

a0f195cc Merge pull request kubernetes-csi#106 from msau42/fix-canary 7100c120 Only set staging registry when running canary job b3c65f9c Merge pull request kubernetes-csi#99 from msau42/add-release-process e53f3e85 Merge pull request kubernetes-csi#103 from msau42/fix-canary d1294628 Document new method for adding CI jobs are new K8s versions e73c2ce5 Use staging registry for canary tests 2c098465 Add cleanup instructions to release-notes generation 60e1cd3 Merge pull request kubernetes-csi#98 from pohly/kubernetes-1-19-fixes 0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18 3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0 1fbb636 Merge pull request kubernetes-csi#97 from pohly/go-1.15 82d108a switch to Go 1.15 d8a2530 Merge pull request kubernetes-csi#95 from msau42/add-release-process 843bddc Add steps on promoting release images 0345a83 Merge pull request kubernetes-csi#94 from linux-on-ibm-z/bump-timeout 1fdf2d5 cloud build: bump timeout in Prow job 41ec6d1 Merge pull request kubernetes-csi#93 from animeshk08/patch-1 5a54e67 filter-junit: Fix gofmt error 0676fcb Merge pull request kubernetes-csi#92 from animeshk08/patch-1 36ea4ff filter-junit: Fix golint error f5a4203 Merge pull request kubernetes-csi#91 from cyb70289/arm64 43e50d6 prow.sh: enable building arm64 image 0d5bd84 Merge pull request kubernetes-csi#90 from pohly/k8s-staging-sig-storage 3df86b7 cloud build: k8s-staging-sig-storage c5fd961 Merge pull request kubernetes-csi#89 from pohly/cloud-build-binfmt db0c2a7 cloud build: initialize support for running commands in Dockerfile be902f4 Merge pull request kubernetes-csi#88 from pohly/multiarch-windows-fix 340e082 build.make: optional inclusion of Windows in multiarch images 5231f05 build.make: properly declare push-multiarch 4569f27 build.make: fix push-multiarch ambiguity 17dde9e Merge pull request kubernetes-csi#87 from pohly/cloud-build bd41690 cloud build: initial set of shared files 9084fec Merge pull request kubernetes-csi#81 from msau42/add-release-process 6f2322e Update patch release notes generation command 0fcc3b1 Merge pull request kubernetes-csi#78 from ggriffiths/fix_csi_snapshotter_rbac_version_set d8c76fe Support local snapshot RBAC for pull jobs c1bdf5b Merge pull request kubernetes-csi#80 from msau42/add-release-process ea1f94a update release tools instructions 152396e Merge pull request kubernetes-csi#77 from ggriffiths/snapshotter201_update 7edc146 Update snapshotter to version 2.0.1 4cf843f Merge pull request kubernetes-csi#76 from pohly/build-targets 3863a0f build for multiple platforms only in CI, add s390x 8322a7d Merge pull request kubernetes-csi#72 from pohly/hostpath-update 7c5a89c prow.sh: use 1.3.0 hostpath driver for testing b8587b2 Merge pull request kubernetes-csi#71 from wozniakjan/test-vet fdb3218 Change 'make test-vet' to call 'go vet' d717c8c Merge pull request kubernetes-csi#69 from pohly/test-driver-config a1432bc Merge pull request kubernetes-csi#70 from pohly/kubelet-feature-gates 5f74333 prow.sh: also configure feature gates for kubelet 84f78b1 prow.sh: generic driver installation 3c34b4f Merge pull request kubernetes-csi#67 from windayski/fix-link fa90abd fix incorrect link ff3cc3f Merge pull request kubernetes-csi#54 from msau42/add-release-process ac8a021 Document the process for releasing a new sidecar 23be652 Merge pull request kubernetes-csi#65 from msau42/update-hostpath 6582f2f Update hostpath driver version to get fix for connection-timeout 4cc9174 Merge pull request kubernetes-csi#64 from ggriffiths/snapshotter_2_version_update 8191eab Update snapshotter to version v2.0.0 3c463fb Merge pull request kubernetes-csi#61 from msau42/enable-snapshots 8b0316c Fix overriding of junit results by using unique names for each e2e run 5f444b8 Merge pull request kubernetes-csi#60 from saad-ali/updateHostpathVersion af9549b Update prow hostpath driver version to 1.3.0-rc2 f6c74b3 Merge pull request kubernetes-csi#57 from ggriffiths/version_gt_kubernetes_fix fc80975 Fix version_gt to work with kubernetes prefix 9f1f3dd Merge pull request kubernetes-csi#56 from msau42/enable-snapshots b98b2ae Enable snapshot tests in 1.17 to be run in non-alpha jobs. 9ace020 Merge pull request kubernetes-csi#52 from msau42/update-readme 540599b Merge pull request kubernetes-csi#53 from msau42/fix-make a4e6299 fix syntax for ppc64le build 771ca6f Merge pull request kubernetes-csi#49 from ggriffiths/prowsh_improve_version_gt d7c69d2 Merge pull request kubernetes-csi#51 from msau42/enable-multinode 4ad6949 Improve snapshot pod running checks and improve version_gt 53888ae Improve README by adding an explicit Kubernetes dependency section 9a7a685 Create a kind cluster with two worker nodes so that the topology feature can be tested. Test cases that test accessing volumes from multiple nodes need to be skipped 4ff2f5f Merge pull request kubernetes-csi#50 from darkowlzz/kind-0.6.0 80bba1f Use kind v0.6.0 6d674a7 Merge pull request kubernetes-csi#47 from Pensu/multi-arch 8adde49 Merge pull request kubernetes-csi#45 from ggriffiths/snapshot_beta_crds 003c14b Add snapshotter CRDs after cluster setup a41f386 Merge pull request kubernetes-csi#46 from mucahitkurt/kind-cluster-cleanup 1eaaaa1 Delete kind cluster after tests run. 83a4ef1 Adding build for ppc64le 4fcafec Merge pull request kubernetes-csi#43 from pohly/system-pod-logging f41c135 prow.sh: also log output of system containers ee22a9c Merge pull request kubernetes-csi#42 from pohly/use-vendor-dir 8067845 travis.yml: also use vendor directory 23df4ae prow.sh: use vendor directory if available a53bd4c Merge pull request kubernetes-csi#41 from pohly/go-version c8a1c4a better handling of Go version 5e773d2 update CI to use Go 1.13.3 f419d74 Merge pull request kubernetes-csi#40 from msau42/add-1.16 e0fde8c Add new variables for 1.16 and remove 1.13 adf00fe Merge pull request kubernetes-csi#36 from msau42/full-clone f1697d2 Do full git clones in travis. Shallow clones are causing test-subtree errors when the depth is exactly 50. 2c81919 Merge pull request kubernetes-csi#34 from pohly/go-mod-tidy 518d6af Merge pull request kubernetes-csi#35 from ddebroy/winbld2 2d6b3ce Build Windows only for amd64 c1078a6 go-get-kubernetes.sh: automate Kubernetes dependency handling 194289a update Go mod support 0affdf9 Merge pull request kubernetes-csi#33 from gnufied/enable-hostpath-expansion 6208f6a Enable hostpath expansion 6ecaa76 Merge pull request kubernetes-csi#30 from msau42/fix-windows ea2f1b5 build windows binaries with .exe suffix 2d33550 Merge pull request kubernetes-csi#29 from mucahitkurt/create-2-node-kind-cluster a8ea8bc create 2-node kind cluster since topology support is added to hostpath driver df8530d Merge pull request kubernetes-csi#27 from pohly/dep-vendor-check 35ceaed prow.sh: install dep if needed f85ab5a Merge pull request kubernetes-csi#26 from ddebroy/windows1 9fba09b Add rule for building Windows binaries 0400867 Merge pull request kubernetes-csi#25 from msau42/fix-master-jobs dc0a5d8 Update kind to v0.5.0 aa85b82 Merge pull request kubernetes-csi#23 from msau42/fix-master-jobs f46191d Kubernetes master changed the way that releases are tagged, which needed changes to kind. There are 3 changes made to prow.sh: 1cac3af Merge pull request kubernetes-csi#22 from msau42/add-1.15-jobs 0c0dc30 prow.sh: tag master images with a large version number f4f73ce Merge pull request kubernetes-csi#21 from msau42/add-1.15-jobs 4e31f07 Change default hostpath driver name to hostpath.csi.k8s.io 4b6fa4a Update hostpath version for sidecar testing to v1.2.0-rc2 ecc7918 Update kind to v0.4.0. This requires overriding Kubernetes versions with specific patch versions that kind 0.4.0 supports. Also, feature gate setting is only supported on 1.15+ due to kind.sigs.k8s.io/v1alpha3 and kubeadm.k8s.io/v1beta2 dependencies. a6f21d4 Add variables for 1.15 db8abb6 Merge pull request kubernetes-csi#20 from pohly/test-driver-config b2f4e05 prow.sh: flexible test driver config 0399988 Merge pull request kubernetes-csi#19 from pohly/go-mod-vendor 066143d build.make: allow repos to use 'go mod' for vendoring 0bee749 Merge pull request kubernetes-csi#18 from pohly/go-version e157b6b update to Go 1.12.4 88dc9a4 Merge pull request kubernetes-csi#17 from pohly/prow 0fafc66 prow.sh: skip sanity testing if component doesn't support it bcac1c1 Merge pull request kubernetes-csi#16 from pohly/prow 0b10f6a prow.sh: update csi-driver-host-path 0c2677e Merge pull request kubernetes-csi#15 from pengzhisun/master ff9bce4 Replace 'return' to 'exit' to fix shellcheck error c60f382 Merge pull request kubernetes-csi#14 from pohly/prow 7aaac22 prow.sh: remove AllAlpha=all, part II 6617773 Merge pull request kubernetes-csi#13 from pohly/prow cda2fc5 prow.sh: avoid AllAlpha=true 546d550 prow.sh: debug failing KinD cluster creation 9b0d9cd build.make: skip shellcheck if Docker is not available aa45a1c prow.sh: more efficient execution of individual tests f3d1d2d prow.sh: fix hostpath driver version check 31dfaf3 prow.sh: fix running of just "alpha" tests f501443 prow.sh: AllAlpha=true for unknown Kubernetes versions 95ae9de Merge pull request kubernetes-csi#9 from pohly/prow d87eccb prow.sh: switch back to upstream csi-driver-host-path 6602d38 prow.sh: different E2E suite depending on Kubernetes version 741319b prow.sh: improve building Kubernetes from source 29545bb prow.sh: take Go version from Kubernetes source 429581c prow.sh: pull Go version from travis.yml 0a0fd49 prow.sh: comment clarification 2069a0a Merge pull request kubernetes-csi#11 from pohly/verify-shellcheck 55212ff initial Prow test job 6c7ba1b build.make: integrate shellcheck into "make test" b2d25d4 verify-shellcheck.sh: make it usable in csi-release-tools 3b6af7b Merge pull request kubernetes-csi#12 from pohly/local-e2e-suite 104a1ac build.make: avoid unit-testing E2E test suite 34010e7 Merge pull request kubernetes-csi#10 from pohly/vendor-check e6db50d check vendor directory fb13c51 verify-shellcheck.sh: import from Kubernetes 94fc1e3 build.make: avoid unit-testing E2E test suite 849db0a Merge pull request kubernetes-csi#8 from pohly/subtree-check-relax cc564f9 verify-subtree.sh: relax check and ignore old content 33d58fd Merge pull request kubernetes-csi#5 from pohly/test-enhancements be8a440 Merge pull request kubernetes-csi#4 from pohly/canary-fix b0336b5 build.make: more readable "make test" output 09436b9 build.make: fix pushing of "canary" image from master branch 147892c build.make: support suppressing checks 154e33d build.make: clarify usage of "make V=1" git-subtree-dir: release-tools git-subtree-split: a0f195cc2ddc2a1f07d4d3e46fc08187db358f94

…RS-and-OWNERS_ALIASES OCPBUGS-14814: Chore: Update OWNERS and OWNERS_ALIASES

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2019

k8s-ci-robot requested review from msau42 and pohly August 14, 2019 07:32

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2019

msau42 reviewed Aug 14, 2019

View reviewed changes

k8s-ci-robot assigned msau42 Aug 14, 2019

ddebroy mentioned this pull request Aug 20, 2019

Support CSI plugins in Windows kubernetes/enhancements#1122

Closed

jingxu97 reviewed Aug 21, 2019

View reviewed changes

Build Node Driver Registrar for Windows nodes

216c2aa

Signed-off-by: Deep Debroy <ddebroy@docker.com>

ddebroy force-pushed the windows1 branch from dbf1b63 to 216c2aa Compare August 28, 2019 13:08

jingxu97 reviewed Sep 4, 2019

View reviewed changes

andyzhangx mentioned this pull request Sep 5, 2019

CSI driver support on Windows kubernetes-sigs/azuredisk-csi-driver#45

Closed

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019

k8s-ci-robot merged commit 21825d3 into kubernetes-csi:master Sep 5, 2019

pohly pushed a commit to pohly/node-driver-registrar that referenced this pull request Feb 14, 2020

Merge pull request kubernetes-csi#47 from Pensu/multi-arch

6d674a7

Adding build for ppc64le

pohly mentioned this pull request Oct 12, 2020

master: update release-tools #115

Merged

dobsonj pushed a commit to dobsonj/node-driver-registrar that referenced this pull request Oct 16, 2023

Merge pull request kubernetes-csi#47 from mpatlasov/Chore-Update-OWNE…

bbc5591

…RS-and-OWNERS_ALIASES OCPBUGS-14814: Chore: Update OWNERS and OWNERS_ALIASES

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Node Driver Registrar for Windows nodes #47

Build Node Driver Registrar for Windows nodes #47

ddebroy commented Aug 14, 2019

k8s-ci-robot commented Aug 14, 2019

ddebroy commented Aug 14, 2019

ddebroy commented Aug 14, 2019

msau42 Aug 14, 2019

msau42 Aug 14, 2019

ddebroy Aug 14, 2019

msau42 Aug 14, 2019

msau42 commented Aug 14, 2019

k8s-ci-robot commented Aug 14, 2019

msau42 commented Aug 20, 2019

jingxu97 Aug 21, 2019 •

edited

Loading

ddebroy Aug 22, 2019 •

edited

Loading

jingxu97 Aug 22, 2019

ddebroy Aug 28, 2019

ddebroy commented Aug 28, 2019 •

edited

Loading

ddebroy commented Aug 28, 2019

msau42 commented Aug 29, 2019

msau42 commented Aug 29, 2019

k8s-ci-robot commented Aug 29, 2019

jingxu97 Sep 4, 2019

ddebroy Sep 4, 2019

jingxu97 commented Sep 4, 2019

k8s-ci-robot commented Sep 4, 2019

andyzhangx commented Sep 5, 2019

andyzhangx commented Sep 5, 2019

msau42 commented Sep 5, 2019

k8s-ci-robot commented Sep 5, 2019

Build Node Driver Registrar for Windows nodes #47

Build Node Driver Registrar for Windows nodes #47

Conversation

ddebroy commented Aug 14, 2019

k8s-ci-robot commented Aug 14, 2019

ddebroy commented Aug 14, 2019

ddebroy commented Aug 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Aug 14, 2019

k8s-ci-robot commented Aug 14, 2019

msau42 commented Aug 20, 2019

jingxu97 Aug 21, 2019 • edited Loading

Choose a reason for hiding this comment

ddebroy Aug 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ddebroy commented Aug 28, 2019 • edited Loading

ddebroy commented Aug 28, 2019

msau42 commented Aug 29, 2019

msau42 commented Aug 29, 2019

k8s-ci-robot commented Aug 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingxu97 commented Sep 4, 2019

k8s-ci-robot commented Sep 4, 2019

andyzhangx commented Sep 5, 2019

andyzhangx commented Sep 5, 2019

msau42 commented Sep 5, 2019

k8s-ci-robot commented Sep 5, 2019

jingxu97 Aug 21, 2019 •

edited

Loading

ddebroy Aug 22, 2019 •

edited

Loading

ddebroy commented Aug 28, 2019 •

edited

Loading