-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanity: allow Volume
capacity_bytes
to be zero
#262
Conversation
From the CSI spec: > The capacity of the volume in bytes. This field is OPTIONAL. If not > set (value of 0), it indicates that the capacity of the volume is > unknown (e.g., NFS share). > The value of this field MUST NOT be negative. As such, the tests that validate the result of a `CreateVolume` operation shall accept zero as the `capacity_bytes` of the returned `Volume` object, when validating this value against the requested capacity. See: kubernetes-csi#94 See: https://github.com/container-storage-interface/spec/blob/e129a75169c13bade7c7336afe21f259740ba679/spec.md#createvolume
Welcome @NicolasT! |
Hi @NicolasT. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jsafrane |
/ok-to-test |
/lgtm Thanks for the fix! One last thing, can you add a release note for this fix? You can "/hold cancel" afterwards. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, NicolasT The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
From the CSI spec:
As such, the tests that validate the result of a
CreateVolume
operation shall accept zero as the
capacity_bytes
of the returnedVolume
object, when validating this value against the requestedcapacity.
See: https://github.com/container-storage-interface/spec/blob/e129a75169c13bade7c7336afe21f259740ba679/spec.md#createvolume
Which issue(s) this PR fixes:
Related to #94 but not fixing it completely (cfr. #263).
Special notes for your reviewer:
Does this PR introduce a user-facing change?: