Mock topology testing #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
msau42
reviewed
Feb 14, 2020
mock/service/controller.go
Outdated
| @@ -58,6 +63,18 @@ func (s *service) CreateVolume( | |||
| return nil, status.Errorf(codes.OutOfRange, "Requested capacity %d exceeds maximum allowed %d", capacity, MaxStorageCapacity) | |||
| } | |||
|
|
|||
| // Simulate "out of storage space" error? | |||
| if capacityLimit := req.GetParameters()["capacityLimit"]; capacityLimit != "" { | |||
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
needs-rebase
This is off by default. If enabled, the mock driver returns the capability for topology and a fixed "io.kubernetes.storage.mock/node: some-mock-node" topology segment for the node it runs on and all volumes. This makes it possible to test some more code paths in external-provisioner.
pohly
force-pushed
the
mock-topology-testing
branch
from
e4eb990
to
5024dd3
Compare
k8s-ci-robot
removed
the
needs-rebase
|
I've stripped out the error injection and rewrote kubernetes/kubernetes#88114 to use JavaScript error injection. What's left is just the optional topology support. Can we merge this now? Then I'll do a csi-test release. |
|
That should also unblock kubernetes/kubernetes#89041. |
|
/lgtm |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
For testing the upcoming "unset selected node" feature in external-provisioner.
Which issue(s) this PR fixes:
Related-to: kubernetes/kubernetes#72031
Special notes for your reviewer:
This could be merged as-is, but it might also make sense to first review the other PRs.
Does this PR introduce a user-facing change?: