Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go module requirements for semantic versioning #232

Merged
merged 4 commits into from
Nov 4, 2019

Commits on Oct 28, 2019

  1. Fix go module requirements for semantic versioning

    As stated in this blog post:
    https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
    modules that release a version higher than 1 need to put the version
    into the package path.
    Christian Schulze-Wiehenbrauk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    6b40e09 View commit details
    Browse the repository at this point in the history
  2. Version bump to v3

    Christian Schulze-Wiehenbrauk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    91151b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. v3: ensure that dep can import v3.0.0

    These symlinks ensure that "dep" can still import v3.0.0. Without
    them, importing fails when it encounters the
    github.com/kubernetes-csi/csi-test/v3 because there's no code under
    that path without the symlinks. Symlinks work for files, but not for
    directories (probably due to a check in dep which expects directories
    for packages).
    
    Upstream suggests to move the code itself ("Major subdirectory",
    https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher). But
    that messes with git history. Symlinks are simpler, but have the
    disadvantage of only working on Unix. Users on Windows will have to
    use "go mod" for importing.
    pohly authored and Christian Schulze-Wiehenbrauk committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    0163355 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Add readme for v3 dir

    Christian Schulze-Wiehenbrauk committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    4c648a1 View commit details
    Browse the repository at this point in the history