Skip to content

Commit

Permalink
v3: ensure that dep can import v3.0.0
Browse files Browse the repository at this point in the history
These symlinks ensure that "dep" can still import v3.0.0. Without
them, importing fails when it encounters the
github.com/kubernetes-csi/csi-test/v3 because there's no code under
that path without the symlinks. Symlinks work for files, but not for
directories (probably due to a check in dep which expects directories
for packages).

Upstream suggests to move the code itself ("Major subdirectory",
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher). But
that messes with git history. Symlinks are simpler, but have the
disadvantage of only working on Unix. Users on Windows will have to
use "go mod" for importing.
  • Loading branch information
pohly authored and Christian Schulze-Wiehenbrauk committed Oct 29, 2019
1 parent 91151b0 commit 0163355
Show file tree
Hide file tree
Showing 19 changed files with 19 additions and 0 deletions.
1 change: 1 addition & 0 deletions v3/driver/driver-controller.go
1 change: 1 addition & 0 deletions v3/driver/driver-node.go
1 change: 1 addition & 0 deletions v3/driver/driver.go
1 change: 1 addition & 0 deletions v3/driver/driver.mock.go
1 change: 1 addition & 0 deletions v3/driver/mock.go
1 change: 1 addition & 0 deletions v3/mock/cache/SnapshotCache.go
1 change: 1 addition & 0 deletions v3/mock/service/controller.go
1 change: 1 addition & 0 deletions v3/mock/service/identity.go
1 change: 1 addition & 0 deletions v3/mock/service/node.go
1 change: 1 addition & 0 deletions v3/mock/service/service.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/cleanup.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/controller.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/identity.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/node.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/sanity.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/tests.go
1 change: 1 addition & 0 deletions v3/pkg/sanity/util.go
1 change: 1 addition & 0 deletions v3/utils/grpcutil.go
1 change: 1 addition & 0 deletions v3/utils/safegoroutinetester.go

0 comments on commit 0163355

Please sign in to comment.