Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump image versions #528

Merged
merged 1 commit into from
Jun 3, 2024
Merged

bump image versions #528

merged 1 commit into from
Jun 3, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Prepare to update kubernetes e2e manifests. HonorPVReclaimPolicy is promoted to beta in csi-provisioner:v5.0.0

Which issue(s) this PR fixes:

Ref kubernetes/kubernetes#124842

Special notes for your reviewer:

/hold

We are working on cutting new releases of all sidecars before updating csi hostpath manifests and cutting a new release of csi hostpath.

Does this PR introduce a user-facing change?:

bump image versions

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2024
@carlory
Copy link
Member Author

carlory commented May 27, 2024

/cc @xing-yang

I will update this PR once new releases of all sidecars are ready.

@xing-yang
Copy link
Contributor

Can you update the csi-external-health-monitor-controller image to v0.12.0?

@carlory
Copy link
Member Author

carlory commented May 30, 2024

@xing-yang updated.

we plan to promote VAC to beta in v1.31. so the external-provisioner and external-resizer need to be updated. do we need to wait for them to be ready before releasing the hostpath driver?

@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@jsafrane
Copy link
Contributor

we plan to promote VAC to beta in v1.31. so the external-provisioner and external-resizer need to be updated. do we need to wait for them to be ready before releasing the hostpath driver?

We need to release the CSI driver for v1.30 first. Release for v1.31 will have v1.31-ish provisioned and resized.

@carlory
Copy link
Member Author

carlory commented Jun 3, 2024

hold until the image registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0 is available.

related to:

@xing-yang
Copy link
Contributor

/hold cancel

We are not sure when the Windows issue will be fixed. We can update the images again when they are updated later.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit a35f07d into kubernetes-csi:master Jun 3, 2024
10 checks passed
@carlory
Copy link
Member Author

carlory commented Jun 4, 2024

Just a note: the following images are unavailable.

cc @xing-yang @jsafrane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@gnufied gnufied Awaiting requested review from gnufied

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlory @xing-yang @jsafrane @k8s-ci-robot