update deployment_crud.py to include a restart_deployment method for typed client

[Priyankasaggu11929]

What type of PR is this?

/kind documentation
/kind cleanup

What this PR does / why we need it:

This PR updates the examples/deployment_crud.py python script, to add a rolling_restart_deployment method. This new method demonstrates how to perform a rolling restart on a deployment resource using the k8s python typed client.

The output of the script looks like:

Which issue(s) this PR fixes:

Fixes #1378

Does this PR introduce a user-facing change?

NONE

[yliaog]

thanks for the pr
/lgtm
/approve

[yliaog]

/lgtm

[Priyankasaggu11929]

Hi @yliaog, some of the travis CI jobs are failing. I’m unable to understand the issues here. Could you please point me with what might be a fix for this?

https://travis-ci.org/github/kubernetes-client/python/jobs/769364787#L329

thank you.

[yliaog]

from https://travis-ci.org/github/kubernetes-client/python/jobs/769364787#L329

/home/travis/build/kubernetes-client/python/kubernetes/../examples/deployment_crud.py:16:80: E501 line too long (84 > 79 characters)
/home/travis/build/kubernetes-client/python/kubernetes/../examples/deployment_crud.py:89:80: E501 line too long (81 > 79 characters)

[Priyankasaggu11929]

from https://travis-ci.org/github/kubernetes-client/python/jobs/769364787#L329

/home/travis/build/kubernetes-client/python/kubernetes/../examples/deployment_crud.py:16:80: E501 line too long (84 > 79 characters)
/home/travis/build/kubernetes-client/python/kubernetes/../examples/deployment_crud.py:89:80: E501 line too long (81 > 79 characters)

Thank you so much for pointing. I'm trying to fix them.

[yliaog]

closing to trigger CI
/close

[k8s-ci-robot]

@yliaog: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roycaihw]

to fix the pycodestyle test failure, please add an empty line above

[roycaihw]

to fix the pycodestyle test failure, please remove the trailing spaces in this line.

[Priyankasaggu11929]

@roycaihw, I fixed the whitespaces issues but the job still remain failing.

Another thing to note:

Just to figure out what exactly amongst the new changes I added, is a breaking change. I started by adding just the following import commands (on top of the example file in master branch)

+ import datetime
+ import pytz
   from kubernetes import client, config

The job is still failing. https://travis-ci.org/github/kubernetes-client/python/jobs/770894221

I'm not sure if I'm missing something really simple here?

[roycaihw]

pycodestyle is asking for some empty lines between the imports. Sorry the tool has a strong opinion about standard v.s. third-party imports-- imports in different categories need to be separated by empty lines.

diff --git a/examples/deployment_crud.py b/examples/deployment_crud.py
index 4fd02a7..7dcd6b3 100644
--- a/examples/deployment_crud.py
+++ b/examples/deployment_crud.py
@@ -17,7 +17,9 @@ Creates, updates, and deletes a deployment using AppsV1Api.
 """
 
 import datetime
+
 import pytz
+
 from kubernetes import client, config
 
 DEPLOYMENT_NAME = "nginx-deployment"
ERROR: InvocationError for command /home/travis/build/kubernetes-client/python/scripts/update-pycodestyle.sh (exited with code 1)

[Priyankasaggu11929]

@roycaihw, @yliaog, finally everything is green now 😄

Sorry, it caused a lot of trouble due to repeated failing tests (& me not understanding what exactly it required). But, I definitely learnt a lot about the tool.

Thank you so much.

[yliaog]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment