Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

ConvertPyTorchJobToUnstructured uses function ToUnstructured to convert PyTorchJob to Unstructured instead of json #241

Merged
merged 11 commits into from
Dec 18, 2019

Conversation

leileiwan
Copy link
Contributor

In the PR kubernetes/kubernetes#86291 we use json to convert PyTorchJob to Unstructured ,the test case will not pass. The code has potential problem.

so, I suggest to use function ToUnstructured to instead of json

@k8s-ci-robot
Copy link

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.97% when pulling 771f3d5 on leileiwan:master into 26f9d0c on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

Thanks for your contribution! 🎉 👍

/lgtm

@johnugeorge
Copy link
Member

@leileiwan
Copy link
Contributor Author

@leileiwan Can you also add it to tf-operator repo too? https://github.com/kubeflow/tf-operator/blob/master/pkg/common/util/v1/testutil/util.go

ok,iwill

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fec4b00 into kubeflow:master Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants