Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

add kubeconfig flag #192

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 31, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

Enable defining kubeconfig path in flag.

Mirror PR: kubeflow/training-operator#1049

Signed-off-by: yeya24 <yb532204897@gmail.com>
@k8s-ci-robot
Copy link

Hi @yeya24. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/ok-to-test

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

LGTM 👍
/lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.281% when pulling 284145a on yeya24:add-kubeconfig-flag into 4028276 on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e98eb3c into kubeflow:master Jul 31, 2019
@yeya24 yeya24 deleted the add-kubeconfig-flag branch July 31, 2019 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants