Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

set annotation automatically when EnableGangScheduling is set to true… #181

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

zlcnju
Copy link
Contributor

@zlcnju zlcnju commented Jun 25, 2019

1032

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link

Hi @zlcnju. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jun 25, 2019

Coverage Status

Coverage remained the same at 85.217% when pulling 1ef54f0 on zlcnju:master into 213df9c on kubeflow:master.

@johnugeorge
Copy link
Member

Thanks for the PR.
Can you sign CLA?

@johnugeorge
Copy link
Member

/ok-to-test

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@zlcnju
Copy link
Contributor Author

zlcnju commented Jun 26, 2019

@johnugeorge clas signed

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6aa39a4 into kubeflow:master Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants