Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

gopkg: Use version instead of branch #107

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Nov 20, 2018

Ref kubeflow/training-operator#872

Using version allows us to be compatible with more versions.

/cc @zjj2wry

/assign @johnugeorge


This change is Reviewable

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 66.937% when pulling 5c2d076 on gaocegege:1.10 into a72fa86 on kubeflow:master.

@k8s-ci-robot k8s-ci-robot merged commit 7e969e7 into kubeflow:master Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants