Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): clean up kfp-kubernetes documentation index page #11207

Conversation

gregsheremeta
Copy link
Contributor

Description of your changes:

The entry page for kfp-kubernetes was a little lacking. Clean it up a bit.

Checklist:

@HumairAK
Copy link
Contributor

/lgtm
/approve

@rimolive
Copy link
Member

/lgtm

The entry page for kfp-kubernetes was a little lacking. Clean it up
a bit.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
@gregsheremeta gregsheremeta force-pushed the clean-up-kfp-kubernetes-doc-entry-page branch from 4183925 to d72820f Compare September 13, 2024 14:39
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 13, 2024
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gregsheremeta
Copy link
Contributor Author

/rerun-all

@google-oss-prow google-oss-prow bot merged commit c642949 into kubeflow:master Sep 14, 2024
7 checks passed
@gregsheremeta
Copy link
Contributor Author

@chensun how do we get the readthedocs page updated? Old content is still there: https://kfp-kubernetes.readthedocs.io/en/kfp-kubernetes-1.3.0/

sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
…ow#11207)

The entry page for kfp-kubernetes was a little lacking. Clean it up
a bit.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
…ow#11207)

The entry page for kfp-kubernetes was a little lacking. Clean it up
a bit.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
…ow#11207)

The entry page for kfp-kubernetes was a little lacking. Clean it up
a bit.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 20, 2024
…ow#11207)

The entry page for kfp-kubernetes was a little lacking. Clean it up
a bit.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants