Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata envoy): upgrade envoy and config from 1.12 to 1.27 #10589

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

freefood89
Copy link
Contributor

Description of your changes:
Upgrades envoy metadata proxy from 1.12 to 1.27 since 1.12 is no longer supported and is not receiving patches. I chose 1.27 because it's the version supported by the istio version I am using istio docs

This is my first PR here! I might need some help validating that this doesn't break anything.

closes #10578

Checklist:

Signed-off-by: Rentaro Matsukata <freefood89@users.noreply.github.com>
Copy link

Hi @freefood89. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@freefood89 freefood89 changed the title upgrade envoy and config from 1.12 to 1.27 fix(metadata envoy): upgrade envoy and config from 1.12 to 1.27 Mar 20, 2024
@freefood89
Copy link
Contributor Author

As suggested by @rimolive I navigated to Executions, Artifacts, and then Lineage in Artifacts and I see no errors in the console or network tab of chrome dev tools. The run I used was "[Tutorial] DSL - Control structures"

The kubeflow I'm using is 1.8 deployed using kubeflow/manifests

@rimolive
Copy link
Member

Thank you for your contribution @freefood89 !

/ok-to-test

@thesuperzapper
Copy link
Member

This seems reasonable, and will help with the effort to make native ARM64 images:

The old envoyproxy/envoy:v1.12.2 tag does not have an ARM64 variant, but the new envoyproxy/envoy:v1.27.3 one does.

/lgtm

@rimolive
Copy link
Member

/assign @chensun @Tomcli

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 96aaad9 into kubeflow:master Mar 25, 2024
3 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…flow#10589)

Signed-off-by: Rentaro Matsukata <freefood89@users.noreply.github.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…flow#10589)

Signed-off-by: Rentaro Matsukata <freefood89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] upgrade metadata envoy
5 participants