Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues running v2 pipeline #2828

Closed
wants to merge 1 commit into from
Closed

Conversation

papagala
Copy link

@papagala papagala commented Aug 1, 2024

Fixing V2 pipeline RBAC issues related to ParallelFor

Running v2 pipelines using ParallelFor in Kubeflow 1.8.1 and 1.9.0 results in an RBAC error. This issue is due to a missing resource in the aggregate-to-kubeflow-pipelines-edit ClusterRole. As a result, ParallelFor pipelines compiled with KFP 2.8.0 fail while executing them on the Kubeflow cluster.

time="2024-07-25T10:11:07.236Z" level=info msg="Create workflowtaskresults 403"
error="workflowtaskresults.argoproj.io is forbidden: User \"system:serviceaccount:dummyusernamespace:default-editor\" cannot create resource \"workflowtaskresults\" in API group \"argoproj.io\" in the namespace \"dummyusernamespace\""

After making this changes I successfully ran V2 pipeline's ParallelFor functionality.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gkcalat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
@juliusvonkohout
Copy link
Member

@papagala thank you for the PR, but you are not allowed to touch the upstream folders. This has to be fixed in https://github.com/kubeflow/pipelines where the manifests come from.

CC @rimolive

@papagala
Copy link
Author

papagala commented Aug 2, 2024

@papagala thank you for the PR, but you are not allowed to touch the upstream folders. This has to be fixed in https://github.com/kubeflow/pipelines where the manifests come from.

CC @rimolive

Thank you so much. I will open an MR in the proper repository. I appreciate your time. I have opened an MR on the right repo kubeflow/pipelines#11067

@papagala papagala closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants