Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub Actions Failure Due to Missing go-gitlint Tool #129

Closed
wants to merge 2 commits into from
Closed

Fix GitHub Actions Failure Due to Missing go-gitlint Tool #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c756bf1
feat: Updated scripts/githooks/commit-msg
sweep-ai[bot] Dec 28, 2023
2d10a9e
feat: Updated scripts/githooks/pre-commit
sweep-ai[bot] Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/githooks/commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ test "" = "$(grep '^Signed-off-by: ' "$1" |
# TODO: go-gitlint dir set
GITLINT_DIR="./_output/tools/go-gitlint"

if [ ! -f "$GITLINT_DIR" ]; then
printError "go-gitlint not found, installing..."
# Try to install go-gitlint. Attempt both known commands.
make tools || make tools.verify.go-gitlint
fi

$GITLINT_DIR \
--msg-file=$1 \
--subject-regex="^(build|chore|ci|docs|feat|feature|fix|perf|refactor|revert|style|test)(.*)?:\s?.*" \
Expand All @@ -62,7 +68,7 @@ $GITLINT_DIR \
if [ $? -ne 0 ]
then
if ! command -v $GITLINT_DIR &>/dev/null; then
printError "$GITLINT_DIR not found. Please run 'make tools' OR 'make tools.verify.go-gitlint' make verto install it."
printError "$GITLINT_DIR not found and has been installed. Please run 'make tools' OR 'make tools.verify.go-gitlint' if the issue persists."
fi
printError "Please fix your commit message to match kubecub coding standards"
printError "https://gist.github.com/cubxxw/126b72104ac0b0ca484c9db09c3e5694#file-githook-md"
Expand Down
10 changes: 10 additions & 0 deletions scripts/githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ printMessage "Running local kubecub pre-commit hook."

# flutter format .
# https://gist.github.com/cubxxw/126b72104ac0b0ca484c9db09c3e5694#file-githook-md
# Check if go-gitlint is available and install if necessary
if [ ! -f "${GITLINT_DIR}" ]; then
printError "${GITLINT_DIR} not found, installing..."
make tools || make tools.verify.go-gitlint
fi
if [ ! -f "$GITLINT_DIR" ]; then
printError "go-gitlint not found and has been installed. Please run 'make tools' OR 'make tools.verify.go-gitlint' if the issue persists."
make tools || make tools.verify.go-gitlint
fi

# TODO! GIT_FILE_SIZE_LIMIT=50000000 git commit -m "test: this commit is allowed file sizes up to 50MB"
# Maximum file size limit in bytes
limit=${GIT_FILE_SIZE_LIMIT:-2000000} # Default 2MB
Expand Down
Loading