Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp dir for new base image #3647

Merged
merged 1 commit into from
Sep 9, 2024
Merged

tmp dir for new base image #3647

merged 1 commit into from
Sep 9, 2024

Conversation

jessegoodier
Copy link
Collaborator

@jessegoodier jessegoodier commented Sep 9, 2024

What does this PR change?

add tmp dirs for new nginx base image

Does this PR rely on any other PRs?

FE image change PR

How does this PR impact users? (This is the kind of thing that goes in release notes!)

New frontend base image

What risks are associated with merging this PR? What is required to fully test this PR?

NA

How was this PR tested?

live test on nightly
template:

        volumes:
          - name: tmp
          emptyDir: {}
          volumeMounts:
            - name: tmp
              mountPath: /tmp
            - name: tmp
              mountPath: /var/lib/nginx/tmp
            - name: tmp
              mountPath: /var/run

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

@jessegoodier
Copy link
Collaborator Author

/cherry-pick v2.4

Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM!!

@jessegoodier jessegoodier merged commit 0b09e5b into develop Sep 9, 2024
36 checks passed
@jessegoodier jessegoodier deleted the frontend-base-image branch September 9, 2024 17:13
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 9, 2024
jessegoodier added a commit that referenced this pull request Sep 9, 2024
Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants