[ENG-2674] Add routes for savings recommendations allow list validation API #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancaburtoiu
force-pushed
the
biancaburtoiu/eng-2674
branch
from
bff4629
to
e64c55e
Compare
biancaburtoiu
force-pushed
the
biancaburtoiu/eng-2674
branch
from
e64c55e
to
ba48150
Compare
kubecost-pb
approved these changes
Sep 6, 2024
nik-kc
approved these changes
Sep 6, 2024
biancaburtoiu
added a commit
that referenced
this pull request
Sep 6, 2024
…on API (#3635) * [ENG-2674] Add routes * Drop location from kubecost.yaml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds routes for the
/savings/recommendations/allowListsAPI in the nginx config.Does this PR rely on any other PRs?
API implementation: https://github.com/kubecost/kubecost-cost-model/pull/2772
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users can use this API to validate whether the supplied instance type allowlists contain valid instance types.
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2674
What risks are associated with merging this PR? What is required to fully test this PR?
N/A
How was this PR tested?
N/A
Have you made an update to documentation? If so, please provide the corresponding PR.
N/A