Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix carbonEstimates typo #3490

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

jessegoodier
Copy link
Collaborator

What does this PR change?

Fix inconsistent carbonEstimates values

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

NA, never was a release. Shout out to @srpomeroy for the find.

What risks are associated with merging this PR? What is required to fully test this PR?

None

How was this PR tested?

helm install with

kubecostProductConfigs:
  carbonEstimates: true

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

@jessegoodier
Copy link
Collaborator Author

/cherry-pick v2.3

@jessegoodier jessegoodier enabled auto-merge (squash) June 20, 2024 11:38
Copy link
Member

@nealormsbee nealormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch.

@jessegoodier jessegoodier merged commit a02072f into develop Jun 20, 2024
15 checks passed
@jessegoodier jessegoodier deleted the backwakrds-compatible-carbonenabled branch June 20, 2024 12:32
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 20, 2024
jessegoodier added a commit that referenced this pull request Jun 20, 2024
Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants