Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root user compatibility defaults #2730

Merged
merged 2 commits into from
Nov 3, 2023
Merged

root user compatibility defaults #2730

merged 2 commits into from
Nov 3, 2023

Conversation

jessegoodier
Copy link
Collaborator

What does this PR change?

Prevent applying new container security contraints when using root user.

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Add a note that using ports under 1025 and root user will be deprecated in a future release.

Links to Issues or tickets this PR addresses or fixes

#2710

What risks are associated with merging this PR? What is required to fully test this PR?

Should be low risk and simply allow for backwards compatibility.

How was this PR tested?

Using helm settings provider in issue:

service:
  host: kubecost
  port: 80

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

Copy link
Collaborator

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deprecate now? We can add a warning into NOTES.txt if this configuration is detected warning of deprecation.

@jessegoodier
Copy link
Collaborator Author

Can we deprecate now? We can add a warning into NOTES.txt if this configuration is detected warning of deprecation.

Will wait for 2.0

@chipzoller
Copy link
Collaborator

Can we deprecate now? We can add a warning into NOTES.txt if this configuration is detected warning of deprecation.

Will wait for 2.0

Added to internal tracking list for 2.0.

@chipzoller chipzoller self-requested a review November 3, 2023 19:17
@jessegoodier jessegoodier merged commit 852faf9 into develop Nov 3, 2023
2 of 3 checks passed
@jessegoodier jessegoodier deleted the nginx-root-scc branch November 3, 2023 19:17
jessegoodier added a commit that referenced this pull request Nov 3, 2023
* root user compatibility defaults

* spacing
jessegoodier added a commit that referenced this pull request Nov 3, 2023
* root user compatibility defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants