remove replicasets from core (fix #2662) #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chipzoller <chipzoller@gmail.com>
jessegoodier
approved these changes
Oct 23, 2023
ameijer
pushed a commit
that referenced
this pull request
Oct 23, 2023
Signed-off-by: chipzoller <chipzoller@gmail.com> (cherry picked from commit 66280eb)
ameijer
added a commit
that referenced
this pull request
Oct 30, 2023
…etl-utils-pod * commit 'b675a8cacaa5b6c64cf00d3583df026cfc2ec507': (28 commits) exec (#2701) swap jimmidyson/configmap-reload for prometheus-operator/prometheus-config-reloader (#2698) update savedReports and advancedReports in values.yml to reflect current filter schema add systemProxy env vars (#2687) feat(cost-analyzer): add StatefulSet as option (#2188) [Feature] Development guide and devcontainers (#2680) Bump actions/checkout from 4.1.0 to 4.1.1 (#2683) remove replicasets from core (#2678) networkCosts service discovery (#2677) Begin Helm testing (#2674) update securityContexts (#2669) consistent image name for aggregator (#2676) Add version matrix and more tests (#2664) label consistency (#2673) setting to 50h to match etl retention time (#2667) pv sizing proxy for wf add missing bracket add ability to override cc sa name Added /savings/localLowDisks proxy for Aggregator. update perms (#2662) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chipzoller chipzoller@gmail.com
What does this PR change?
Removes an incorrectly-placed
replicasetsresource from the core API group.Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or tickets this PR addresses or fixes
Fixes an issue caused in #2662
What risks are associated with merging this PR? What is required to fully test this PR?
How was this PR tested?
Have you made an update to documentation? If so, please provide the corresponding PR.