Default disable KSM #2573
Merged
Default disable KSM #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegoodier
approved these changes
Sep 8, 2023
|
@AjayTripathy I remember there was a reason why you wanted to keep this enabled for some period. Any risks to consider? |
|
@dwbrown2 I haven't found any missing metrics since then. But happy to dig in if Ajay has concerns. |
|
No major concerns. We kept it enabled to bake but since august we have moved further away from our reliance on KSM. |
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Proposal to default disable kube-state-metrics (KSM) for all users moving forward. Users still have the option to enable the bundled KSM if they choose.
This has the advantage of simplifying the user's install process, and reducing likelihood they would need to troubleshoot Prometheus metrics during install. Especially in cases where users already have KSM running in their environment. And especially in cases where users are bringing their own Prometheus which already houses some KSMv2 metrics.
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Kubecost's bundled kube-state-metrics deployment is now disabled by default.
Links to Issues or tickets this PR addresses or fixes
None
What risks are associated with merging this PR? What is required to fully test this PR?
Low risk. We do not lose anything significant when KSM is disabled. Users are able to re-enable Kubecost's bundled KSM if they wish.
Note, that this change impacts users who are intentionally running Kubecost's bundled KSM for the purposes of higher availability metrics. I suggest we widely announce the default disabling of KSM in release notes.
How was this PR tested?
Running Kubecost without KSM has been common practice and tested for many releases now. It is also what is recommended in the poc-common-configurations repo.
Have you made an update to documentation? If so, please provide the corresponding PR.
kubecost/docs#752