Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check err on Client::request_stream #1433

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: check err on Client::request_stream #1433

merged 1 commit into from
Mar 21, 2024

Conversation

XciD
Copy link
Contributor

@XciD XciD commented Mar 21, 2024

Motivation

request_stream dont return an Err in case of Http Error

Solution

Re-use the same method as request_text, with a little refactoring

Signed-off-by: Adrien <adrien@huggingface.co>
@clux clux added the changelog-fix changelog fix category for prs label Mar 21, 2024
@clux clux added this to the 0.89.0 milestone Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.3%. Comparing base (df37c99) to head (f579a5c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1433     +/-   ##
=======================================
+ Coverage   72.2%   72.3%   +0.2%     
=======================================
  Files         75      76      +1     
  Lines       6485    6533     +48     
=======================================
+ Hits        4680    4722     +42     
- Misses      1805    1811      +6     
Files Coverage Δ
kube-client/src/client/mod.rs 72.2% <77.8%> (+0.3%) ⬆️

... and 4 files with indirect coverage changes

@XciD XciD closed this Mar 21, 2024
@XciD XciD deleted the fix-handle-error-stream branch March 21, 2024 16:45
@XciD XciD restored the fix-handle-error-stream branch March 21, 2024 17:10
@XciD XciD reopened this Mar 21, 2024
@XciD
Copy link
Contributor Author

XciD commented Mar 21, 2024

(don't know why it was closed)

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clux clux changed the title fix: check err on request_stream fix: check err on Client::request_stream Mar 21, 2024
@clux clux merged commit 88b8941 into kube-rs:main Mar 21, 2024
33 checks passed
@clux clux linked an issue Mar 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check HTTP status code in request_stream
2 participants