Update kube-client's rustls dependency to 0.21.4
#1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kube-client is incompatible with rustls versions prior to 0.21.4 due to the renaming of rustls::client::builder::ConfigBuilder::.with_client_auth_cert Fixes #1340 Signed-off-by: Mathias Pius <contact@pius.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
+ Coverage 72.1% 72.2% +0.1%
=======================================
Files 75 75
Lines 6377 6377
=======================================
+ Hits 4597 4598 +1
+ Misses 1780 1779 -1 |
clux
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-client is incompatible with rustls versions prior to
0.21.4due to the renaming ofrustls::client::builder::ConfigBuilder::.with_client_auth_certFixes #1340
Motivation
It is not currently possible to build
kube-clientusing the stated minimum dependencies in its cargo manifest.Solution
Updating kube-client's rustls dependency to
0.21.4which is its actual minimum supported version.