Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils.version with packaging.version's parse #36

Closed
wants to merge 1 commit into from

Conversation

hugovk
Copy link

@hugovk hugovk commented Nov 12, 2021

Fixes #35.

Demo

Python 3.10.0 (v3.10.0:b494f5935c, Oct  4 2021, 14:59:20) [Clang 12.0.5 (clang-1205.0.22.11)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from packaging.version import parse as parse_version
>>> import pytest
>>> parse_version(pytest.__version__)
<Version('6.2.5')>
>>> parse_version('3.6.0')
<Version('3.6.0')>
>>> parse_version(pytest.__version__) < parse_version('3.6.0')
False

Copy link

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eraserhead0705
Copy link

Any idea when we can see this released? Work around for me is currently manually changing the code in my venv.

@taybin
Copy link

taybin commented Feb 1, 2022

I'm seeing this too now. Any updates?

@lyz-code
Copy link

@ktosiek @thijskramer @pquentin is there anything we can do to speed up the merging of this PR?

kbevers added a commit to kbevers/pytest-freezegun-feedstock that referenced this pull request Feb 16, 2022
Patch supplied upstream [0] but the maintainer hasn't merged it and there
are signs of the project being abandoned. This is a temporary fix
until the future of the project is resolved.

[0] ktosiek/pytest-freezegun#36
kbevers added a commit to kbevers/pytest-freezegun-feedstock that referenced this pull request Feb 16, 2022
Patch supplied upstream [0] but the maintainer hasn't merged it and there
are signs of the project being abandoned. This is a temporary fix
until the future of the project is resolved.

[0] ktosiek/pytest-freezegun#36
kbevers added a commit to kbevers/pytest-freezegun-feedstock that referenced this pull request Feb 16, 2022
Patch supplied upstream [0] but the maintainer hasn't merged it and there
are signs of the project being abandoned. This is a temporary fix
until the future of the project is resolved.

[0] ktosiek/pytest-freezegun#36
@gabriel-yahav
Copy link

@ktosiek @thijskramer @pquentin is there anything we can do to speed up the merging of this PR?

Joining the question.

  1. Is there any issue block merging this PR ?
  2. When will a new release's version be available ?

@mgorny
Copy link

mgorny commented Apr 8, 2022

Honestly, at this point I do wonder if there's really a point in supporting pytest < 3.6.0, and if it wouldn't be better to just drop that and avoid the extra dep.

@hugovk
Copy link
Author

hugovk commented Apr 8, 2022

Good idea, please see #38 as an alternative.

@hugovk
Copy link
Author

hugovk commented Nov 16, 2022

Closing this year old PR, happy to re-open if there's any interest, but will keep #38 open a bit longer.

@hugovk hugovk closed this Nov 16, 2022
@youknowone
Copy link

@ktosiek would you try to recruit more maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace distutils.version with packaging.version.path
9 participants