Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated no-unused-variable Rule #4

Closed
wants to merge 1 commit into from

Conversation

todd
Copy link

@todd todd commented Aug 14, 2018

TSLint has deprecated no-unused-variable and now recommends using the built in compiler checks in TypeScript >= 2.9 to achieve the same result.

@krzkaczor
Copy link
Owner

Hey,
the problem that I have with this setting is that it interrupts compiling. Also I can't find any note about deprecation in docs :/ https://palantir.github.io/tslint/rules/no-unused-variable/ Am i missing something?

@todd
Copy link
Author

todd commented Aug 15, 2018

See palantir/tslint#3919 for details on the deprecation - I guess they haven't updated their docs yet. However, TSLint will log a deprecation warning when attempting to use this option, which is how I found out about it in the first place.

@krzkaczor
Copy link
Owner

krzkaczor commented Aug 15, 2018

Yeah, I noticed that warning as well but given the current state of tsc flag, i can't agree to remove this rule.

Here's a little bit more discussion about removing deprecation: palantir/tslint#4100 (also it was de-deprecated already once xD) main points being:

  • it's compiler error not warning
  • you cannot specify ignore pattern

Thanks for bringing this issue and I am sure that we should reconsider this in a few months and see where the community goes. I will leave a note in the readme about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants