Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcmod 7.2 issue #20

Closed
krowinski opened this issue Apr 30, 2018 · 4 comments
Closed

bcmod 7.2 issue #20

krowinski opened this issue Apr 30, 2018 · 4 comments
Assignees
@krowinski
Labels
important

Comments

@krowinski
Copy link
Owner

As of 7.2 float can be passed to bcmod but they don't return correct values (IMO)

I created bug for this in https://bugs.php.net/bug.php?id=76287 but it was commented as documentation issue not a bug.

bcmod() doesn't use floor() but rather truncates towards zero,
which is also defined this way for POSIX fmod(), so that the
result always has the same sign as the dividend.  Therefore, this
is not a bug, but rather a documentation issue.

But I still will use floor not truncated for fmod in this lib.
@krowinski krowinski self-assigned this May 17, 2018
krowinski added a commit that referenced this issue May 17, 2018
@krowinski
* change: getDecimalsLengthFromNumber set to public #21
0e8e4b6 
* remove: fmod - removed php7.2 as is not working as intended #20
* added: for 7.2 0 as scale for bcmod to keep compatibility with 7.1 mod
* added: php 7.2 travis tests
@peter279k
Copy link
Contributor

@krowinski, do you have any idea about this?
It looks like we have to do something for bcomd function in php-7.2.

@krowinski
Copy link
Owner Author

? I wrote this and its already fix in this lib its here just for info

@peter279k
Copy link
Contributor

@krowinski, thank you for your reply. I've seen that. And this issue should be closed?

And add some info in README.md.

krowinski added a commit that referenced this issue Dec 5, 2018
@krowinski
added bitwise xor, or and "and" #20
da4416f
krowinski added a commit that referenced this issue Dec 11, 2018
@krowinski
added bitwise xor, or and "and" (#28)
9d435fd 
* added bitwise xor, or and "and" #27 
* readme update #20
@krowinski
Copy link
Owner Author

added info in readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krowinski krowinski

Labels
important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krowinski @peter279k