Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kwarg when Psych::VERSION >= 3.1.0 #98

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

BobbyMcWho
Copy link

@BobbyMcWho BobbyMcWho commented Sep 27, 2022

resolves #96

This technically doesn't break until Psych 4.0+, but positional args were deprecated in 3.1.0

@BobbyMcWho
Copy link
Author

@ssinghi @sbhawsingka mind reviewing and merging?

@ssinghi ssinghi merged commit 11abf22 into kreeti:master Nov 19, 2022
@abartov
Copy link

abartov commented Jan 28, 2023

Has this been released yet? I'm running into this problem with Ruby 3.2, with kt-paperclip 7.1.1

@abartov
Copy link

abartov commented Feb 16, 2023

Confirming that this was not released. For anyone encountering this issue, setting your Gemfile to use the git HEAD works for now.

gem 'kt-paperclip', git: 'https://github.com/kreeti/kt-paperclip.git' # for Ruby 3.2 compatibility, until https://github.com/kreeti/kt-paperclip/pull/98 is officially released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue with Ruby 3.1
4 participants