Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the type at the end of the method call #84

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Return the type at the end of the method call #84

merged 1 commit into from
Feb 9, 2022

Conversation

ngan
Copy link

@ngan ngan commented Feb 9, 2022

This is to fix a bug where if @type_from_marcel does not equal SENSIBLE_DEFAULT, nil is returned instead of the @type_from_marcel that was discovered on line 72:

      @type_from_marcel = Marcel::MimeType.for Pathname.new(@filepath),
                                               name: @filepath

@ngan
Return the type at the end of the method call
3740120 
This is to fix a bug where if `@type_from_marcel` does not equal `SENSIBLE_DEFAULT`, `nil` is returned instead of the `@type_from_marcel` that was discovered on line 72:

```ruby
      @type_from_marcel = Marcel::MimeType.for Pathname.new(@filepath),
                                               name: @filepath
```
@ngan
Copy link
Author

ngan commented Feb 9, 2022

cc @ssinghi @jeffse

I think this is a pretty gnarly bug and we should cut another release ASAP 😄

@ssinghi ssinghi merged commit 6d3cfb9 into kreeti:master Feb 9, 2022
@ngan ngan deleted the patch-2 branch February 9, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbhawsingka sbhawsingka sbhawsingka approved these changes

Assignees

@ssinghi ssinghi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngan @sbhawsingka @ssinghi