Utilize the filename as a hint when mimetype matches multiple types #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file detection returns multiple types, then use marcel's ability to use the filename as a secondary hint to narrow the type further.
|
@jeffse Can we please fix the suggestions given by hound? Thanks! |
sbhawsingka
approved these changes
Jan 10, 2022
I fixed the Hound issues, although it seems that Hound isn't picking up the configuration from .hound.yml properly. I'll see if I rectify that in another branch. |
Yes, kind of. I was going to do the same thing but didn’t want to break backwards compatibility in case marcel did things differently that what was happening today inside this gem when it comes to file type. But I’m all for this simpler approach. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file detection returns multiple types, then use marcel's ability to use the filename as a secondary hint to narrow the type further.
I think this is the same thing that @ngan is trying to accomplish with #74 but using the logic built in to the marcel gem.